laji
New Member
Posts: 12
|
Post by laji on Mar 13, 2016 2:30:11 GMT
Hi R3peat,
I noticed some settings path is wrong on the latest release. Dug around the source and saw you changed : AppDomain.CurrentDomain.BaseDirectory to path.AppDir on some files (Me.cs, T_ExternalFile.cs, etc)
It seems that path.AppDir doesn't append a backspace character at the end of the path, breaking the resulting path string.
HTH
|
|
laji
New Member
Posts: 12
|
Post by laji on Mar 13, 2016 9:49:30 GMT
Also,
There is a bug in determining item quality for upgrading rares in the Cube, it should be AND instead of OR
In file D3Helper\A_Handler\AutoCube\Tools.cs
if (quality >= 6 || quality <= 8) should be
if (quality >= 6 && quality <= 8)
HTH
Sorry I'm not familiar with Github (or any source code repos), I tried but still unable to figure out how to fork/pull these changes
|
|
laji
New Member
Posts: 12
|
Post by laji on Mar 14, 2016 17:25:09 GMT
Thanks for the pull and new release, this thread should be irrelevant now.
|
|