contributing to d3helper git project
Feb 3, 2016 21:28:48 GMT
Post by techdough on Feb 3, 2016 21:28:48 GMT
Hi r3peat,
Thank you for your work so far and really understand your other priorities. So first of all thank you!
I am someone who wants to contribute to your open source project. Yesterdays breakage was a good way to see whats working and whats not working. I think overall a simple process is missing to coordinate all our efforts. Here is what I suggest, or need you to set in motion to streamline everything.
1) Should we have a contributors/developers forum here, so developers can go into one place and ask questions, discuss solutions etc? Or else we are going to be posting stuff in general and your release threads, which isn't 100% appropriate and organized. Also spams the rest of your users.
2) should we be using the git hub issues, github.com/r3peat/D3Helper.Public/issues rather than the forums to post bugs? This way we can link our fixes to git hub issues and its easier for contributors to see what bugs people are running into and take up the issues. Ofcourse its up to you if you want to pull back a fix into the main trunk or not. Example, github.com/twbs/bootstrap/issues
3) In your latest fix, it seems the model you are following on git hub is 1 root folder for each release version and within it the fixes. Issue with this is when we are trying to learn what you did to fix a bug its pretty hard to see the diffs. github.com/r3peat/D3Helper.Public/commit/8b3f1112c8e7bd7decfec47d1037ef0017362e22 according to this there are hundreds of changes mainly because you checked all the files in. I think it would be best to take the versions out as the root folder, and the root folder is just the latest snapshot of the code. You can have github "Releases" feature to track your releases. For example see, github.com/twbs/bootstrap and github.com/twbs/bootstrap/releases
4) What modifications did you make to enigma? Can this be documented or some sort of a merge readme be written up? I went through enigma source code and yours and saw that the main diff is that you don't have all the libraries he does. Knowing what you changed and how to pull in changes from enigma's checkins to d3helper is going to be really important for us to maintain the software effectively. Needless to say, if memory address change and we have no idea how to read them, the software becomes useless. I also saw that engigma for latest patch just updated some enums. It seemed enigma added ability to read bonusbounties detecting. I went to diff your checkin to see how you interpreted enigma's changes but ofcourse due to project set up I wasn't able to self learn this.
I know you are trying to lessen your work load but I think taking care of these will go a long way to setting a process for us to take over and also ensure the stuff we want to do is quality work. Once this gets going I think you can be pretty hands off!
Thanks!
Thank you for your work so far and really understand your other priorities. So first of all thank you!
I am someone who wants to contribute to your open source project. Yesterdays breakage was a good way to see whats working and whats not working. I think overall a simple process is missing to coordinate all our efforts. Here is what I suggest, or need you to set in motion to streamline everything.
1) Should we have a contributors/developers forum here, so developers can go into one place and ask questions, discuss solutions etc? Or else we are going to be posting stuff in general and your release threads, which isn't 100% appropriate and organized. Also spams the rest of your users.
2) should we be using the git hub issues, github.com/r3peat/D3Helper.Public/issues rather than the forums to post bugs? This way we can link our fixes to git hub issues and its easier for contributors to see what bugs people are running into and take up the issues. Ofcourse its up to you if you want to pull back a fix into the main trunk or not. Example, github.com/twbs/bootstrap/issues
3) In your latest fix, it seems the model you are following on git hub is 1 root folder for each release version and within it the fixes. Issue with this is when we are trying to learn what you did to fix a bug its pretty hard to see the diffs. github.com/r3peat/D3Helper.Public/commit/8b3f1112c8e7bd7decfec47d1037ef0017362e22 according to this there are hundreds of changes mainly because you checked all the files in. I think it would be best to take the versions out as the root folder, and the root folder is just the latest snapshot of the code. You can have github "Releases" feature to track your releases. For example see, github.com/twbs/bootstrap and github.com/twbs/bootstrap/releases
4) What modifications did you make to enigma? Can this be documented or some sort of a merge readme be written up? I went through enigma source code and yours and saw that the main diff is that you don't have all the libraries he does. Knowing what you changed and how to pull in changes from enigma's checkins to d3helper is going to be really important for us to maintain the software effectively. Needless to say, if memory address change and we have no idea how to read them, the software becomes useless. I also saw that engigma for latest patch just updated some enums. It seemed enigma added ability to read bonusbounties detecting. I went to diff your checkin to see how you interpreted enigma's changes but ofcourse due to project set up I wasn't able to self learn this.
I know you are trying to lessen your work load but I think taking care of these will go a long way to setting a process for us to take over and also ensure the stuff we want to do is quality work. Once this gets going I think you can be pretty hands off!
Thanks!
-> Forum.